Update sed command for additional workloads #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for SNAFU CI Test
|
|
Looks like a good place to use a loop 😉 |
|
@sjug We should really just utilize the image override function in the benchmark operator workload yaml files but yeah. ie But for the moment I just want it to work so the other pip fixes can pass and be merged. Then we need to revisit CI across the baord since the wrapper and operator also conflict with each other when run at the same time... |
mohit-sheth
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI was not properly being run on image pull and log generator workloads because the image strings were not getting updated.
Fixes
CI was not working for image pull and log generator