get fs-drift to pass CI again #414
Conversation
|
ok this is strange error message, all 6 checks above pass but the message is "8 successful and 1 failing check"??? |
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 15 15
Lines 869 869
=======================================
Hits 342 342
Misses 527 527
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I have pushed a real fix to fs-drift benchmark-wrapper above (as well as pushing a fix to fs-drift benchmark itself). investigating pre-commit.ci error during build while testing my hand-built image (which built successfully). |
|
The error during build is nothing to do with me, it is CI system not being able to authenticate itself. Please help. |
|
this is ready to merge, has been tested in AWS with fs-drift and OCP 4.9 . The one CI check above that failed is nothing to do with fs-drift. Can someone please merge this? |
|
what did I do wrong to cause CI not to pass? Last night the image build failed with github authentication error. |
bengland2
force-pushed
the
fs-drift-json-fix
branch
from
d1ac925
to
0ee9c82
Compare
|
/rerun all |
|
Issue lies with our pre-commit config, I'll push a fix here in a second. |
|
@bengland2 can you merge in the updated pre-commit config from master? |
this is not a real fix, we need to process response time data and process counter data into rates over time but at least the code is structured more reasonably now JSON parsing is removed from this module can be fixed later as time permits
have to run each one as an iterator because of yield
bengland2
force-pushed
the
fs-drift-json-fix
branch
from
0ee9c82
to
a8a66c9
Compare
|
@learnitall I rebased my changes and it still fails but for reasons I can do something about now, thank you! |
|
Thank you for your patience with the pre-commit issues. TIL to stay up to date on GitHub's blog to stay informed on these sorts of changes. |
this is not a real fix, we need to
process response time data and
process counter data into rates over time
but at least the code is structured more reasonably now
JSON parsing is removed from this module
can be fixed later as time and interest permits