Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed Enable false condition issue. #32

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Fix: Fixed Enable false condition issue. #32

merged 5 commits into from
Jan 12, 2024

Conversation

nileshgadgi
Copy link
Member

what

  • Updated the output with try function to prevent any Error while enabled variable is false.
  • Renamed example files and removed variables.tf as they exist and managed from in root directory itself.
  • Removed unused variable.
  • Update target_key_id in main.tf to prevent error while enabled variable is false.

why

  • While passing enabled as false, was getting the error in outputs and target_key_id argement.
  • Was receiving blank output (expected no changes) while planning the terraform code.

@nileshgadgi nileshgadgi added the bug Something isn't working label Oct 26, 2023
@nileshgadgi nileshgadgi self-assigned this Oct 26, 2023
@themaniskshah
Copy link
Member

@dependabot rebase

@vaibhav7797 vaibhav7797 self-requested a review January 12, 2024 08:47
theprashantyadav
theprashantyadav approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@theprashantyadav theprashantyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vaibhav7797
vaibhav7797 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themaniskshah themaniskshah merged commit ac16b3b into master Jan 12, 2024
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/condition branch January 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@theprashantyadav theprashantyadav theprashantyadav approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@d4kverma d4kverma Awaiting requested review from d4kverma

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@h1manshu98 h1manshu98 Awaiting requested review from h1manshu98

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@VishwajitNagulkar VishwajitNagulkar Awaiting requested review from VishwajitNagulkar

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nileshgadgi @themaniskshah @theprashantyadav @vaibhav7797 @anmolnagpal