Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of cluster deployed from cluster.yml #151

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

clevesque
Copy link
Contributor

Allows finer grain control on exactly which type cluster to deploy from a cluster.yml file, the default legacy behavior remains (it creates all clusters found in a cluster.yml file). Can provide a "-e to_deploy=" in command line current values: base
encryption (a kts cluster)
compute
ecs
Thanks npopa@cloudera.com
Signed-off-by: Chuck Levesque clevesque@cloudera.com

Allows finer grain control on exactly which type cluster to deploy from a cluster.yml file, the default legacy behavior remains (it creates all clusters found in a cluster.yml file).
Can provide a "-e to_deploy=<value>" in command line current values:
base
encryption  (a kts cluster)
compute
ecs
Thanks npopa@cloudera.com
Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@wmudge wmudge requested a review from a team October 26, 2023 13:40
@wmudge wmudge added the enhancement New feature or request label Oct 26, 2023
@wmudge wmudge added this to the Release 4.1.0 milestone Oct 26, 2023
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, however, the variable name is not right. How about something like deploy_only?

@wmudge wmudge modified the milestones: Release 4.1.0, Release 4.2.0 Nov 2, 2023
@cloudera-labs cloudera-labs deleted a comment from clevesque Nov 3, 2023
Allows finer grain control on exactly which type cluster to deploy from a cluster.yml file, the default legacy behavior remains (it creates all clusters found in a cluster.yml file).
Can provide a "-e deploy_only=<value>" in command line current values:
base
encryption  (a kts cluster)
compute
ecs
Thanks npopa@cloudera.com
Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@clevesque
Copy link
Contributor Author

change made

@wmudge wmudge merged commit 905661c into cloudera-labs:devel Nov 13, 2023
4 checks passed
@clevesque clevesque deleted the feature-selection branch December 22, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validated
Development

Successfully merging this pull request may close these issues.

2 participants