Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap search filters - allow literal expression #163

Merged

Conversation

clevesque
Copy link
Contributor

@clevesque clevesque commented Nov 15, 2023

Older implementation assumed all ldap filters end with "={0}" This newer implementation allows the user to craft any legal filter expression, including complex compound expressions, like ((&(member={0})(objectclass=posixgroup)(!(cn=admins))) above is example IPA group search filter for ECS 1.5.x

Older implementation assumed all ldap filters end with "={0}"
This newer implementation allows the user to craft any legal filter expression, including complex compound expressions, like
((&(member={0})(objectclass=posixgroup)(!(cn=admin)))
above is example IPA group search filter for ECS 1.5.x

Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@wmudge wmudge requested a review from a team November 20, 2023 18:00
@wmudge wmudge added the enhancement New feature or request label Nov 20, 2023
@wmudge wmudge added this to the Release 4.3.0 milestone Nov 20, 2023
Older implementation assumed all ldap filters end with "={0}"
This newer implementation allows the user to craft any legal filter expression, including complex compound expressions, like
((&(member={0})(objectclass=posixgroup)(!(cn=admin)))
above is example IPA group search filter for ECS 1.5.x

Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@clevesque
Copy link
Contributor Author

Had to make a simple fix, I relocated j2, file into templates/ where it belongs

Older implementation assumed all ldap filters end with "={0}"
This newer implementation allows the user to craft any legal filter expression, including complex compound expressions, like
((&(member={0})(objectclass=posixgroup)(!(cn=admin)))
above is example IPA group search filter for ECS 1.5.x

Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@github-actions github-actions bot removed the validated label Dec 4, 2023
@clevesque
Copy link
Contributor Author

Fixed jinja syntax error

Older implementation assumed all ldap filters end with "={0}"
This newer implementation allows the user to craft any legal filter expression, including complex compound expressions, like
((&(member={0})(objectclass=posixgroup)(!(cn=admin)))
above is example IPA group search filter for ECS 1.5.x

Signed-off-by: Chuck Levesque <clevesque@cloudera.com>
@github-actions github-actions bot removed the validated label Dec 5, 2023
@clevesque
Copy link
Contributor Author

Fixed a minor typo

@wmudge wmudge merged commit b5b5c88 into cloudera-labs:devel Dec 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validated
Development

Successfully merging this pull request may close these issues.

2 participants