Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster Info Module #204

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

rsuplina
Copy link
Contributor

@rsuplina rsuplina commented Mar 4, 2024

No description provided.

Signed-off-by: rsuplina <rsuplina@cloudera.com>
@rsuplina rsuplina added the enhancement New feature or request label Mar 4, 2024
@rsuplina rsuplina assigned wmudge and jimright and unassigned wmudge and jimright Mar 4, 2024
@rsuplina rsuplina requested review from wmudge and jimright March 4, 2024 12:50
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_info modules return a list of resources unless the resource in question is a singleton. CM manages multiple clusters, so this module needs to accommodate multiple cluster results. If an optional cluster name parameter is included, then the module should return a list with only the single element.

No clusters found should result in an empty list (no dict elements).

plugins/modules/cm_cluster_info.py Outdated Show resolved Hide resolved
plugins/modules/cm_cluster_info.py Outdated Show resolved Hide resolved
plugins/modules/cm_cluster_info.py Outdated Show resolved Hide resolved
plugins/modules/cm_cluster_info.py Outdated Show resolved Hide resolved
Signed-off-by: rsuplina <rsuplina@cloudera.com>
Signed-off-by: rsuplina <rsuplina@cloudera.com>
@wmudge wmudge self-requested a review March 14, 2024 14:20
@wmudge wmudge merged commit 67148e3 into cloudera-labs:devel Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validated
Development

Successfully merging this pull request may close these issues.

3 participants