Fixed handling of custom roleConfig Groups #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a roleConfigGroup was referenced in multiple templates it would be duplicated in the final cluster template. This fix removes the duplication. Signed-off-by: Andre Araujo <araujo@cloudera.com>
Signed-off-by: Andre Araujo <araujo@cloudera.com>
Signed-off-by: Andre Araujo <araujo@cloudera.com>
wmudge
requested changes
Mar 9, 2022
wmudge
approved these changes
Mar 10, 2022
WillDyson
pushed a commit
to WillDyson/cloudera.cluster
that referenced
this pull request
Jul 15, 2022
* Fixed handling of custom roleConfigGroups. When a roleConfigGroup was referenced in multiple templates it would be duplicated in the final cluster template. This fix removes the duplication. Signed-off-by: Andre Araujo <araujo@cloudera.com> * Removed deprecated SMM parameters from template. Signed-off-by: Andre Araujo <araujo@cloudera.com> * Made error message more informative. Signed-off-by: Andre Araujo <araujo@cloudera.com> Signed-off-by: William Dyson <wdyson@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some SMM template updates.