Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update challenge-passage.md #15778

Closed
wants to merge 1 commit into from
Closed

Conversation

vences
Copy link
Contributor

@vences vences commented Jul 24, 2024

Summary

Removed the section that mentioned Rate Limiting + challenge action. It seems in contradiction with that section https://developers.cloudflare.com/waf/rate-limiting-rules/parameters/#:~:text=When%20visitors%20pass%20a%20challenge%2C%20their%20corresponding%20request%20counter%20is%20set%20to%20zero.%20When%20visitors%20with%20the%20same%20values%20for%20the%20rule%20characteristics%20make%20enough%20requests%20to%20trigger%20the%20rate%20limiting%20rule%20again%2C%20they%20will%20receive%20a%20new%20challenge.

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@vences
Copy link
Contributor Author

vences commented Jul 24, 2024

PCX-12393

The Challenge Passage does not apply to challenges issued by WAF managed rules. Also, Challenge Passage does not apply to rate limiting rules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Challenge Passage does not apply to challenges issued by WAF managed rules.

This is not correct.

@migueldemoura migueldemoura requested a review from a team July 24, 2024 15:52
@KimJ15
Copy link
Collaborator

KimJ15 commented Sep 27, 2024

👋Hi there, we’re going to close this PR. All PRs prior to August 12 need to be reworked due to the platform migration to Astro.

@KimJ15 KimJ15 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants