Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] D1 HTTP API tutorial #16412

Merged
merged 11 commits into from
Sep 20, 2024
Merged

[D1] D1 HTTP API tutorial #16412

merged 11 commits into from
Sep 20, 2024

Conversation

harshil1712
Copy link
Contributor

Updated #15779

@github-actions github-actions bot added the product:d1 D1: https://developers.cloudflare.com/d1/ label Aug 23, 2024
Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ceecaf
Status: ✅  Deploy successful!
Preview URL: https://14658654.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://d1-http-tutorial-new.cloudflare-docs-7ou.pages.dev

View logs

Copy link

github-actions bot commented Aug 23, 2024

harshil1712 and others added 2 commits August 23, 2024 15:20
Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>
@Oxyjun Oxyjun self-requested a review as a code owner September 18, 2024 15:54
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 outstanding issue(s) found.

Copy link

gitguardian bot commented Sep 18, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret 81195ad astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 81195ad astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 81195ad astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 outstanding issue(s) found.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 18 outstanding issue(s) found.

Copy link
Contributor Author

@harshil1712 harshil1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oxyjun left a few comments. Just some minor suggestion :D

@dbenCF dbenCF merged commit f75cc76 into production Sep 20, 2024
13 checks passed
@dbenCF dbenCF deleted the d1-http-tutorial-new branch September 20, 2024 13:38
@bllchmbrs
Copy link
Contributor

bllchmbrs commented Sep 21, 2024

@Oxyjun and @dbenCF , hyperlint developer here. I was just looking over this pull request - seems like. a lot of false comments from Hyperlint.

It looks as if the problem was the indentation triggering a lot of false positives. Anything else that you think I'm missing here?

cc @kodster28 for visibility.

We're actively improving the model based on this information, so I want to make sure that we get it right!

One of my questions is, are indentations like this common / going to be more common?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hyperlint-ignore product:d1 D1: https://developers.cloudflare.com/d1/ size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants