Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Site] remove unnecessary DOMContentLoaded listeners #16834

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Sep 14, 2024

Summary

Just some very minor optimisations by not using DOMContentLoaded events. Since all these scripts are processed by Astro, they get defer-ed as type=module, so they're guaranteed to only run when all DOM nodes are accessible.

@Cherry Cherry changed the title fix: remove unnecessary DOMContentLoaded listeners [Docs Site] remove unnecessary DOMContentLoaded listeners Sep 14, 2024
Copy link

gitguardian bot commented Sep 19, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret 238f8ef astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 238f8ef astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 238f8ef astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@KimJ15
Copy link
Collaborator

KimJ15 commented Sep 27, 2024

@KianNH

@KianNH KianNH merged commit e3083ea into cloudflare:production Sep 29, 2024
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Sep 29, 2024
Copy link

holopin-bot bot commented Sep 29, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1my44bl54900ci18lt40nd9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@Cherry Cherry deleted the fix/domcontentloaded branch September 29, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.