Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KV] Get started improvements #17093

Merged
merged 15 commits into from
Sep 27, 2024
Merged

[KV] Get started improvements #17093

merged 15 commits into from
Sep 27, 2024

Conversation

Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Sep 25, 2024

Summary

  1. Clarifying the distinction between binding name and namespace for the CLI workflow.
  2. Adding a parallel workflow which uses the dashboard.
  3. General cleanup for unclear points.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Copy link

gitguardian bot commented Sep 25, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret b7a3ed2 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret b7a3ed2 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret b7a3ed2 astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 total issue(s) found.

src/content/docs/kv/get-started.mdx Outdated Show resolved Hide resolved
src/content/docs/kv/get-started.mdx Show resolved Hide resolved
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bb619d
Status: ✅  Deploy successful!
Preview URL: https://72b5b42b.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://jun-kv-get-started-dashboard.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noticed a change to the style guide files, We resolved the existing comments to account for any changes to your style guide.

src/content/docs/kv/get-started.mdx Show resolved Hide resolved
Oxyjun and others added 9 commits September 27, 2024 10:30
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
@Oxyjun Oxyjun merged commit 2cb41b5 into production Sep 27, 2024
13 of 14 checks passed
@Oxyjun Oxyjun deleted the jun/kv/get-started-dashboard branch September 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:d1 D1: https://developers.cloudflare.com/d1/ product:kv size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants