Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make task id mandatory in DapRequest #684

Merged
merged 1 commit into from
Oct 4, 2024
Merged

make task id mandatory in DapRequest #684

merged 1 commit into from
Oct 4, 2024
+76 −105

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Sep 23, 2024 •
edited
Loading

  • Make task id obligatory in DapRequest
  • Don't pass TaskId by reference

@mendess mendess self-assigned this Sep 23, 2024
@mendess mendess changed the base branch from main to mendess/take-auth-out-of-daphne September 23, 2024 10:40
@mendess mendess force-pushed the mendess/make-task-id-mandatory branch from d9d6325 to 20af072 Compare September 24, 2024 09:01
cjpatton
cjpatton approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch on this one. Note that in draft-02 there were some DAP requests for which we didn't know the task ID, hence it being optional. This is no longer the case in 09 and up.

@mendess mendess force-pushed the mendess/make-task-id-mandatory branch from 20af072 to b2fd190 Compare September 30, 2024 11:31
@mendess mendess force-pushed the mendess/take-auth-out-of-daphne branch from 8710773 to 21d2e20 Compare September 30, 2024 12:00
@mendess mendess force-pushed the mendess/make-task-id-mandatory branch from b2fd190 to edfbf91 Compare September 30, 2024 12:00
@mendess mendess force-pushed the mendess/take-auth-out-of-daphne branch from 21d2e20 to b3de0a2 Compare September 30, 2024 17:39
@mendess mendess force-pushed the mendess/make-task-id-mandatory branch from edfbf91 to 3f9d445 Compare September 30, 2024 17:39
@mendess mendess force-pushed the mendess/take-auth-out-of-daphne branch 6 times, most recently from 90e2ba1 to 6ff2f1d Compare October 1, 2024 17:26
@mendess mendess force-pushed the mendess/make-task-id-mandatory branch from 3f9d445 to eb04b47 Compare October 2, 2024 12:40
@mendess mendess force-pushed the mendess/take-auth-out-of-daphne branch 6 times, most recently from b4bc6fd to 529e136 Compare October 3, 2024 15:48
Base automatically changed from mendess/take-auth-out-of-daphne to main October 4, 2024 08:51
@mendess mendess force-pushed the mendess/make-task-id-mandatory branch 2 times, most recently from 950e460 to 4269682 Compare October 4, 2024 13:14
@mendess mendess merged commit afcabdb into main Oct 4, 2024
4 checks passed
@mendess mendess deleted the mendess/make-task-id-mandatory branch October 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@fisherdarling fisherdarling Awaiting requested review from fisherdarling fisherdarling is a code owner

@cbranch cbranch Awaiting requested review from cbranch cbranch is a code owner

@lbaquerofierro lbaquerofierro Awaiting requested review from lbaquerofierro lbaquerofierro is a code owner

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy Noah-Kennedy is a code owner

@RageKnify RageKnify Awaiting requested review from RageKnify RageKnify is a code owner

Assignees

@mendess mendess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendess @cjpatton