telemetry: make logger verbosity public #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrittenhouse
changed the title
|
You're failing a clippy check, can you remove the Just amend the old commit right now since we can't squash on the reviewers side atm. |
Noah-Kennedy
requested changes
Feb 2, 2024
evanrittenhouse
force-pushed
the
evanrittenhouse/get_verbosity
branch
from
4875336
to
6b14f20
Compare
inikulin
requested changes
Feb 2, 2024
evanrittenhouse
force-pushed
the
evanrittenhouse/get_verbosity
branch
from
6b14f20
to
d908534
Compare
evanrittenhouse
changed the title
inikulin
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
slog-stdlogto read Quiche logs from Foundations, but I want to be able to configure the level of logs they emit. To do so,slog-stdlogexposes aninit_with_levelmethod - we obviously then need to get the verbosity level for the current logger.I didn't see anything that lets us do this, as
Context::current_log()just gets us aSharedLogwhich doesn't expose verbosity/LoggerSettings- if there's an easier way, please feel free to decline this PR.