Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide metrics::add_extra_producer() to enable external metrics #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobrik
Copy link

@bobrik bobrik commented Sep 21, 2024

This is a more forward and backward compatible solution than #65.

@dqminh
Copy link

dqminh commented Sep 25, 2024

This still depends on an implicit assumption that foundations and the additional producers produce only in text format which is very stable, so don't think it will change. If either uses different encoding for whatever reasons, then we will produce broken format.

To make this goaway probably still require the same prometheus_client as seen with #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants