Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomization yaml #26

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ChrisEke
Copy link

@ChrisEke ChrisEke commented Feb 27, 2021

It would be great if a kustomization.yaml was available for easy deployment with kustomize.

@terinjokes
Copy link
Contributor

Thanks for this pull request. I'm not familiar with kustomize. I'm going to read up on that before reviewing.

@diversit
Copy link

diversit commented May 9, 2022

Please add the kustomization.yaml to this project since it would greatly simplify the installation of this project using Kustomize.
At my customer, all K8S service are always deployed via Kustomize since our infra always needs some addition custom configuration like NetworkPolicies, etc. With Kustomize, we can refer to the project's own deployment config (Helm Chart, Kustomize yaml or separate yaml's) and customise those for our environment.
Since origin-ca-issuer uses multiple yaml config's we now have to reference those ourselves and this would break of the project changes these filenames or adds or removes files.
By providing a kustomation.yaml we could just reference that file and automatically get any changes to the yaml configs.

@jdharmavarapu
Copy link

Hi, is this PR going to be merged anytime soon ? I am trying to use kustomize to clone the deploy folder which will make it much easier if we have this feature added.

@terinjokes
Copy link
Contributor

Hello. I'll be revisiting this soon.

@minato128
Copy link

minato128 commented Aug 9, 2022

Hello. We need this too. Thanks!
I believe this has no side effects. So we can merge this.

@Kampe
Copy link

Kampe commented Jul 7, 2023

Would also love to see this merged!

@Kampe
Copy link

Kampe commented Jul 9, 2023

You can test this already by using kustomize built into kubectl:

kubectl kustomize deploy/

I'd however also add a kustomization at the root of the repo so users can install it by doing
kubectl kustomize https://github.com/cloudflare/origin-ca-issuer

To see how this is done you can view: https://github.com/ricoberger/vault-secrets-operator or https://github.com/prometheus-operator/prometheus-operator/blob/main/kustomization.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants