Add GitHub action for testing PR to main #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
approved these changes
Dec 1, 2023
armfazh
reviewed
Dec 1, 2023
| run: npm run lint | ||
|
|
||
| - name: Check build | ||
| run: npm run build |
There was a problem hiding this comment.
add run test so we know is failing
There was a problem hiding this comment.
there are no test script yet. Tracked in #4. At least this action is testing for lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix lint with the addition of a missing semi colon.
CI will fail until the repository is public.