Move Python snapshot logic to its own file #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
requested review from
mikea,
jp4a50 and
dom96
and removed request for
a team
hoodmane
force-pushed
the
hoodmane/snapshot-own-file
branch
from
7f857a5
to
d56b74b
Compare
hoodmane
force-pushed
the
hoodmane/reduce-snapshot-memory-usage
branch
from
84687f2
to
34da5ba
Compare
hoodmane
force-pushed
the
hoodmane/snapshot-own-file
branch
2 times, most recently
from
742fa66
to
fd6c6eb
Compare
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/snapshot-own-file
branch
from
fd6c6eb
to
926b1a4
Compare
Nonfunctional change.
hoodmane
force-pushed
the
hoodmane/snapshot-own-file
branch
from
926b1a4
to
8a33417
Compare
dom96
approved these changes
Apr 3, 2024
| */ | ||
| let READ_MEMORY = undefined; | ||
| let SNAPSHOT_SIZE = undefined; | ||
| export let SHOULD_RESTORE_SNAPSHOT = false; |
There was a problem hiding this comment.
Instead of exporting a global var, we should be returning this value from the appropriate methods.
In general we should work to get rid of global state as much as we can.
There was a problem hiding this comment.
Agreed, but I think fixing this would best be left to a followup; I'm trying to avoid changes if at all possible here b/c moving all the code makes the diff hard to read.
garrettgu10
pushed a commit
that referenced
this pull request
May 13, 2024
Nonfunctional change. This splits python.js (~600 lines) into two files, with ~360 lines moved into snapshot.js. I think it's easier to understand this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonfunctional change. This splits python.js (~600 lines) into two files, with ~360 lines moved into
snapshot.js. I think it's easier to understand this way.