fix: add asset binding to typegen (#6779)

cloudflare · Sep 20, 2024 · 3e75612 · 3e75612
1 parent 7655505
commit 3e75612
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/.changeset/spotty-colts-peel.md b/.changeset/spotty-colts-peel.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: include asset binding in `wrangler types`
diff --git a/packages/wrangler/src/__tests__/type-generation.test.ts b/packages/wrangler/src/__tests__/type-generation.test.ts
@@ -218,6 +218,10 @@ const bindingsConfigMock: Omit<
 		{ type: "CompiledWasm", globs: ["**/*.wasm"], fallthrough: true },
 	],
 	pipelines: [],
+	experimental_assets: {
+		binding: "ASSETS_BINDING",
+		directory: "/assets",
+	},
 };
 
 describe("generateTypes()", () => {
@@ -355,6 +359,7 @@ describe("generateTypes()", () => {
 			BROWSER_BINDING: Fetcher;
 			AI_BINDING: Ai;
 			VERSION_METADATA_BINDING: { id: string; tag: string };
+			ASSETS_BINDING: Fetcher;
 		}
 		declare module \\"*.txt\\" {
 			const value: string;

diff --git a/packages/wrangler/src/type-generation/index.ts b/packages/wrangler/src/type-generation/index.ts
@@ -134,6 +134,7 @@ export async function typesHandler(
 		ai: config.ai,
 		version_metadata: config.version_metadata,
 		secrets,
+		experimental_assets: config.experimental_assets,
 	};
 
 	await generateTypes(
@@ -406,6 +407,12 @@ async function generateTypes(
 		);
 	}
 
+	if (configToDTS.experimental_assets?.binding) {
+		envTypeStructure.push(
+			constructType(configToDTS.experimental_assets.binding, "Fetcher")
+		);
+	}
+
 	const modulesTypeStructure: string[] = [];
 	if (configToDTS.rules) {
 		const moduleTypeMap = {