Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: the default wrangler tail output is too busy #707

Closed
IgorMinar opened this issue Mar 26, 2022 · 4 comments · Fixed by #711 or #679
Closed

🐛 BUG: the default wrangler tail output is too busy #707

IgorMinar opened this issue Mar 26, 2022 · 4 comments · Fixed by #711 or #679

Comments

@IgorMinar
Copy link
Contributor

What version of Wrangler are you using?

0.0.0-52ea60f

What operating system are you using?

mac

Describe the Bug

The default is --format json. Could we change it to --format pretty which is much more user friendly?
@IgorMinar IgorMinar added the bug label Mar 26, 2022
@threepointone
Copy link
Contributor

I think we chose this simply because it's the default in wrangler 1. It's technically a breaking change, but it might be fine. Folks maaay be using it with other tooling, and that may break.

@petebacondarwin
Copy link
Contributor

I think we can get away with pretty being the default. It will be a fairly obvious failure mode for people upgrading from Wrangler 1 and a straightforward fix.

threepointone added a commit that referenced this issue Mar 27, 2022
@threepointone
fix: default wrangler tail to pretty print
df4edb3 
Fixes #707
@threepointone threepointone mentioned this issue Mar 27, 2022
Merged
threepointone added a commit that referenced this issue Mar 27, 2022
@threepointone
fix: default wrangler tail to pretty print
a9067a4 
Fixes #707
threepointone added a commit that referenced this issue Mar 27, 2022
@threepointone
fix: default wrangler tail to pretty print
3606296 
Fixes #707
threepointone added a commit that referenced this issue Mar 27, 2022
@threepointone
fix: default wrangler tail to pretty print
9af652d 
Fixes #707
threepointone added a commit that referenced this issue Mar 27, 2022
@threepointone
fix: default wrangler tail to pretty print
0e883ab 
Fixes #707
@threepointone
Copy link
Contributor

Aight, let's do it. Fix in #711

@threepointone threepointone added this to the 2.0 milestone Mar 28, 2022
threepointone added a commit that referenced this issue Mar 28, 2022
@threepointone
fix: default wrangler tail to pretty print
0a8a6c6 
Fixes #707
petebacondarwin pushed a commit that referenced this issue Mar 28, 2022
@threepointone
fix: default wrangler tail to pretty print (#711)
3dac1da 
Fixes #707
@github-actions github-actions bot mentioned this issue Mar 28, 2022
Merged
@IgorMinar
Copy link
Contributor Author

thank you!

mrbbot added a commit that referenced this issue Oct 31, 2023
@mrbbot
Bump versions to 3.20231002.1 (#707)
5469337
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Bump versions to 3.20231002.1 (#707)
92ba3e8
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Bump versions to 3.20231002.1 (#707)
469f29c
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Bump versions to 3.20231002.1 (#707)
c19627b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Archived in project
Milestone
No milestone
3 participants
@petebacondarwin @threepointone @IgorMinar