Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export functions from dialogs.tsx, pass tests #125

Merged
merged 3 commits into from
Dec 17, 2021
Merged

export functions from dialogs.tsx, pass tests #125

merged 3 commits into from
Dec 17, 2021

Commits on Dec 17, 2021

  1. export functions from dialogs.tsx, pass tests 

    As mentioned in #124 (comment), it's possible to use regular exports from a module, but still be able to mock their implementations in jest. This PR does so, and passes tests.
    @threepointone
    threepointone committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f182eaa View commit details
    Browse the repository at this point in the history

  2. add a changeset

    @threepointone
    threepointone committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    dacc2f3 View commit details
    Browse the repository at this point in the history

  3. copyedit

    @threepointone
    threepointone committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    8bfca73 View commit details
    Browse the repository at this point in the history