Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin chromium/tools/depot_tools to a specific commit #3251

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

sidharthachatterjee
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

It looks like we currently fail on tests because a new set of commits in https://chromium.googlesource.com/chromium/tools/depot_tools.git has broken our workflow in the DevTools publish action. We don't need to be on the bleeding edge here so we are pinning it to a commit that works for now.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

⚠️ No Changeset found

Latest commit: 29a6837

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3251 (29a6837) into main (9f0f612) will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
- Coverage   75.17%   73.86%   -1.32%     
==========================================
  Files         183      549     +366     
  Lines       11055    31361   +20306     
  Branches     2904     7418    +4514     
==========================================
+ Hits         8311    23165   +14854     
- Misses       2744     7926    +5182     
- Partials        0      270     +270     

see 372 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5280953048/npm-package-wrangler-3251

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3251/npm-package-wrangler-3251

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5280953048/npm-package-wrangler-3251 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5280953048/npm-package-cloudflare-pages-shared-3251

Note that these links will no longer work once the GitHub Actions artifact expires.

@petebacondarwin
Copy link
Contributor

This still has CI failures...

@sidharthachatterjee sidharthachatterjee force-pushed the devtools/pin-depot-tools branch 2 times, most recently from a0f82be to 535791d Compare May 18, 2023 16:19
@penalosa penalosa requested a review from a team as a code owner June 15, 2023 15:52
@penalosa penalosa merged commit d96cc85 into main Jun 15, 2023
@penalosa penalosa deleted the devtools/pin-depot-tools branch June 15, 2023 16:41
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
Co-authored-by: Samuel Macleod <smacleod@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants