Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3 e2e #3483

Merged
merged 3 commits into from
Jun 20, 2023
Merged

C3 e2e #3483

merged 3 commits into from
Jun 20, 2023

Conversation

petebacondarwin
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

🦋 Changeset detected

Latest commit: 02f019f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-wrangler-3483

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3483/npm-package-wrangler-3483

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-wrangler-3483 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-cloudflare-pages-shared-3483

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #3483 (c6f35fb) into main (9fd12df) will increase coverage by 0.04%.
The diff coverage is 95.45%.

❗ Current head c6f35fb differs from pull request most recent head 02f019f. Consider uploading reports for the commit 02f019f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3483      +/-   ##
==========================================
+ Coverage   75.18%   75.23%   +0.04%     
==========================================
  Files         183      183              
  Lines       11055    11064       +9     
  Branches     2904     2906       +2     
==========================================
+ Hits         8312     8324      +12     
+ Misses       2743     2740       -3     
Impacted Files Coverage Δ
...angler/src/environment-variables/misc-variables.ts 90.90% <ø> (ø)
packages/wrangler/src/init.ts 93.11% <95.45%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Jun 19, 2023
@petebacondarwin petebacondarwin marked this pull request as ready for review June 19, 2023 18:52
@petebacondarwin petebacondarwin requested review from a team as code owners June 19, 2023 18:52
@petebacondarwin petebacondarwin marked this pull request as draft June 19, 2023 18:52
@petebacondarwin petebacondarwin marked this pull request as ready for review June 19, 2023 20:44
@@ -104,7 +104,7 @@ export function stripTimings(stdout: string): string {
export function npmStripTimings(stdout: string): string {
return stdout
.replace(
/added \d+ packages, and audited \d+ packages in \d+s/,
/added \d+ packages, and audited \d+ packages in [\dms]+/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\d+m?s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is really slow it can take more than a minute, in which case you get ...and audited 20 pages in 1m rather than say ...and audited 20 pages in 60s

});

it("init project via c3", async () => {
const pathToC3 = path.resolve(__dirname, "../../create-cloudflare");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would use the same npm pack approach as Wrangler, but that can be a followup

@petebacondarwin petebacondarwin merged commit a9349a8 into main Jun 20, 2023
@petebacondarwin petebacondarwin deleted the c3-e2e branch June 20, 2023 13:36
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
* fix: ensure that `wrangler init` passes the `name` arg to C3

* e2e clean up for c3 integration testing

* test: add C3 integration test to Wrangler e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants