chore: make D1's experimental backend the default #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21deb80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rozenmd
commented
Jul 24, 2023
| @@ -59,8 +54,8 @@ export const Handler = withConfig<HandlerOptions>( | |||
| }, | |||
| body: JSON.stringify({ | |||
| name, | |||
| experimental: true, | |||
There was a problem hiding this comment.
We can remove this once D1's API defaults to the new backend.
Codecov Report
@@ Coverage Diff @@
## main #3668 +/- ##
==========================================
+ Coverage 75.22% 75.29% +0.06%
==========================================
Files 190 190
Lines 11173 11170 -3
Branches 2948 2945 -3
==========================================
+ Hits 8405 8410 +5
+ Misses 2768 2760 -8
|
Skye-31
reviewed
Jul 24, 2023
Comment on lines
+80
to
+82
| Created your database using D1's new storage backend. The new | ||
| storage backend is not yet recommended for production workloads, but | ||
| backs up your data via point-in-time restore. |
There was a problem hiding this comment.
Should this message be updated?
There was a problem hiding this comment.
Eh we can update that once we go from alpha -> beta, D1 is still not recommended for production workloads until then.
Merged
lrapoport-cf
pushed a commit
that referenced
this pull request
Aug 11, 2023
* chore: make D1's experimental backend the default * fix: actually remove the experimental backend flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3667
What this PR solves / how to test:
wrangler d1 create <dbname>wrangler d1 info <dbname>Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
[ ] TestsReviewer is to perform the following, as applicable: