fix: error when entry doesn't exist #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 04dd7d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
wrangler prerelease is available for testing: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1837915405/wrangler |
threepointone
force-pushed
the
missing-entry-custom-error
branch
from
c234ed2
to
019794f
Compare
threepointone
commented
Feb 12, 2022
threepointone
commented
Feb 13, 2022
petebacondarwin
approved these changes
Feb 13, 2022
This adds an error when we use an entry point that doesn't exist, either for `wrangler dev` or `wrangler publish`, and either via cli arg or `build.upload.main` in `wrangler.toml`. By using a common abstraction for `dev` and `publish`, This also adds support for using `build.config.main`/`build.config.dir` for `wrangler dev`. - Fixes #418 - Fixes #390
threepointone
force-pushed
the
missing-entry-custom-error
branch
from
019794f
to
04dd7d0
Compare
|
I polished it a bit more, looks good imo, landing this. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an error when we use an entry point that doesn't exist, either for
wrangler devorwrangler publish, and either via cli arg orbuild.upload.maininwrangler.toml. By using a common abstraction fordevandpublish, This also adds support for usingbuild.config.main/build.config.dirforwrangler dev.[build.upload.main]/[build.upload.dir]inwrangler dev#418