Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed routes with same paths but different methods from being overwritten on Windows #465

Closed
wants to merge 9 commits into from
Closed

Fixed routes with same paths but different methods from being overwritten on Windows #465

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd42fd4
Added regex to convert backslash to forwardslash in routes
colecrouter Jan 27, 2022
10867b7
Revert "Added regex to convert backslash to forwardslash in routes"
colecrouter Jan 27, 2022
f9bd246
Proper format
colecrouter Jan 27, 2022
a7a1c51
I accidentally deleted my branch again, migrated changes to this one
colecrouter Feb 15, 2022
1a45d1b
Merge branch 'windows-fix' of https://github.com/Mexican-Man/wrangler…
colecrouter Feb 15, 2022
7abf77d
Delete tall-worms-suffer.md
colecrouter Feb 15, 2022
2ff644f
Update filepath-routing.ts
colecrouter Feb 15, 2022
806dac7
Added tests to prevent wrongful deduplication via method
colecrouter Feb 15, 2022
32d9fa0
Merge branch 'windows-fix' of https://github.com/Mexican-Man/wrangler…
colecrouter Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-pugs-relate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Fixed routes with same methods being overriden on Windows(?)
4 changes: 3 additions & 1 deletion packages/wrangler/pages/functions/filepath-routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ export async function generateConfigFromFileTree({
routeEntries = routeEntries.reduce(
(acc: typeof routeEntries, { routePath, ...rest }) => {
const existingRouteEntry = acc.find(
(routeEntry) => routeEntry.routePath === routePath
(routeEntry) =>
routeEntry.routePath === routePath &&
routeEntry.method === rest.method
);
if (existingRouteEntry !== undefined) {
Object.assign(existingRouteEntry, rest);
Expand Down