Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pages Functions example test project #617

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

GregBrimble
Copy link
Member

A simple Functions test project which confirms that:

  • we serve static files
  • we can intercept static files
  • we can SSR responses
  • we can use parameters

@GregBrimble GregBrimble added the pages Relating to Pages label Mar 16, 2022
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! More examples 😄

@GregBrimble GregBrimble merged commit 8c98c00 into main Mar 16, 2022
@GregBrimble GregBrimble deleted the functions-routing-example branch March 16, 2022 17:06
@github-actions github-actions bot mentioned this pull request Mar 16, 2022
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1994105676/npm-package-wrangler-617

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/617/npm-package-wrangler-617

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/1994105676/npm-package-wrangler-617 dev path/to/script.js

@threepointone
Copy link
Contributor

This is breaking tests when running locally because of the open ports :( Could y'all fix this soonish?

@GregBrimble
Copy link
Member Author

#620 :)

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2022

🦋 Changeset detected

Latest commit: 8b51dec

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

threepointone added a commit that referenced this pull request Mar 17, 2022
Looks like we forgot to run `npm install` at the root in #617. Also removed an unnecessary `typescript` dependency.
threepointone added a commit that referenced this pull request Mar 17, 2022
Looks like we forgot to run `npm install` at the root in #617. Also removed an unnecessary `typescript` dependency.
mrbbot added a commit that referenced this pull request Oct 31, 2023
Previously, if source maps included relative paths, those paths would
not be resolved relative to the source map's own file path before
inclusion into stack traces. This meant stack traces included
relative paths that couldn't be resolved for click-to-definition by
IDEs.

This change includes the URL of the source map upon retrieval,
allowing `source-map-support` to include absolute source URLs in
stack traces.
mrbbot added a commit that referenced this pull request Nov 1, 2023
Previously, if source maps included relative paths, those paths would
not be resolved relative to the source map's own file path before
inclusion into stack traces. This meant stack traces included
relative paths that couldn't be resolved for click-to-definition by
IDEs.

This change includes the URL of the source map upon retrieval,
allowing `source-map-support` to include absolute source URLs in
stack traces.
mrbbot added a commit that referenced this pull request Nov 1, 2023
Previously, if source maps included relative paths, those paths would
not be resolved relative to the source map's own file path before
inclusion into stack traces. This meant stack traces included
relative paths that couldn't be resolved for click-to-definition by
IDEs.

This change includes the URL of the source map upon retrieval,
allowing `source-map-support` to include absolute source URLs in
stack traces.
mrbbot added a commit that referenced this pull request Nov 1, 2023
Previously, if source maps included relative paths, those paths would
not be resolved relative to the source map's own file path before
inclusion into stack traces. This meant stack traces included
relative paths that couldn't be resolved for click-to-definition by
IDEs.

This change includes the URL of the source map upon retrieval,
allowing `source-map-support` to include absolute source URLs in
stack traces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants