Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text of Node.js @types/node warning #6541

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

irvinebroque
Copy link
Contributor

@andyjessop small copy change as I go through what we've built to-date

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: ecc8de3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-wrangler-6541

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6541/npm-package-wrangler-6541

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-wrangler-6541 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-create-cloudflare-6541 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-cloudflare-kv-asset-handler-6541
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-miniflare-6541
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-cloudflare-pages-shared-6541
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-cloudflare-vitest-pool-workers-6541
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-cloudflare-workers-editor-shared-6541
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10573356972/npm-package-cloudflare-workers-shared-6541

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thank you.

@andyjessop andyjessop self-assigned this Aug 26, 2024
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Aug 27, 2024
@andyjessop andyjessop marked this pull request as ready for review August 27, 2024 07:07
@andyjessop andyjessop requested a review from a team as a code owner August 27, 2024 07:07
@andyjessop andyjessop merged commit b61a81e into main Aug 27, 2024
28 checks passed
@andyjessop andyjessop deleted the bib/types-node-warning branch August 27, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants