Don't immediately exit on Pages Functions compilation error #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3895828 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2024258092/npm-package-wrangler-671You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/671/npm-package-wrangler-671Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2024258092/npm-package-wrangler-671 dev path/to/script.js |
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
petebacondarwin
approved these changes
Mar 22, 2022
GregBrimble
deleted the
dont-immediately-exit-on-pages-functions-compilation-error
branch
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
There are cases where mutating the URL returned from `Miniflare#ready` may be desirable, e.g. changing the protocol to `ws:` and using the `ws` module to establish a WebSocket connection. Previously, doing this would break Miniflare's `dispatchFetch`, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
There are cases where mutating the URL returned from `Miniflare#ready` may be desirable, e.g. changing the protocol to `ws:` and using the `ws` module to establish a WebSocket connection. Previously, doing this would break Miniflare's `dispatchFetch`, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
There are cases where mutating the URL returned from `Miniflare#ready` may be desirable, e.g. changing the protocol to `ws:` and using the `ws` module to establish a WebSocket connection. Previously, doing this would break Miniflare's `dispatchFetch`, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
There are cases where mutating the URL returned from `Miniflare#ready` may be desirable, e.g. changing the protocol to `ws:` and using the `ws` module to establish a WebSocket connection. Previously, doing this would break Miniflare's `dispatchFetch`, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543
Previously, we'd exit the
wrangler pages devprocess if we couldn't immediately compile a Worker from thefunctionsdirectory. We now log the error, but don't exit the process. This means that proxy processes can be cleaned up cleanly on SIGINT and SIGTERM, and it matches the behavior of if a compilation error is introduced once already running (we don't exit then either).