Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include serialised FormData in debug logs #6854

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 27, 2024

What this PR solves / how to test

Fixes N/A

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e test coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: arguably a bugfix

@penalosa penalosa requested a review from a team as a code owner September 27, 2024 19:39
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: 2500efa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -108,7 +107,7 @@ export class Logger {
}

// only send logs to the terminal if their level is at least the configured log-level
if (LOGGER_LEVELS[this.loggerLevel] >= LOGGER_LEVELS[messageLevel]) {
if (LOGGER_LEVELS[getLoggerLevel()] >= LOGGER_LEVELS[messageLevel]) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this.loggerLevel was pretty much always stale in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant