update check #763
update check #763
Conversation
JacobMGEvans
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: ad13740 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2103676389/npm-package-wrangler-763You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/763/npm-package-wrangler-763Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2103676389/npm-package-wrangler-763 dev path/to/script.js |
packages/wrangler/src/cli.ts
Outdated
| import { main } from "."; | ||
|
|
||
| try { | ||
| initReporting(); | ||
| void updateCheck(); |
There was a problem hiding this comment.
Having this inside the try is probably redundant because it has a try/catch in the updateCheck
|
Alternatively, I started using Ink to improve the UI of this output. I think if we do that it would need to be called around the same place as |
|
I added a new line to create some space, it looked a little cramped in this screenshot |
|
This is with the Ink, implementation I spent some time on.
|
| distTag: "beta", | ||
| }); | ||
| } catch (err) { | ||
| console.error(`Failed to check for updates: ${err}`); |
There was a problem hiding this comment.
This should probably be a silent failure
| console.error(`Failed to check for updates: ${err}`); | ||
| } | ||
|
|
||
| if (update) |
There was a problem hiding this comment.
Does this mean we'll always show this message if there's an update? Do you suppose we only want to show this message once a day?
There was a problem hiding this comment.
The default is it checks once a day.
|
Another idea is to include inside |
I think it is a good idea, we can always pivot later if we want something more like what NPM or similar packages do for their update messaging.
|
JacobMGEvans
force-pushed
the
update-check
branch
from
9fb3b07
to
ee1046e
Compare
…gainst the beta release, distTag can be changed later, then prints the latest beta version to the user. resolves #762
JacobMGEvans
force-pushed
the
update-check
branch
from
ee1046e
to
ad13740
Compare
feat: Added the update check that will check the package once a day against the beta release,
distTagcan be changed later, then prints the latest beta version to the user.resolves #762