Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for environments on secrets command #95

Closed
wants to merge 4 commits into from
Closed

Added support for environments on secrets command #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a207e7
fix(secrets): implemented environment flag
mitchelvanbever Dec 11, 2021
724d7e2
chore: ran npx changeset
mitchelvanbever Dec 11, 2021
03d88b1
fix: should be environments not development
mitchelvanbever Dec 11, 2021
511c410
chore: remov config log
mitchelvanbever Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-readers-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Added support for environments on secrets command
49 changes: 25 additions & 24 deletions packages/wrangler/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,6 @@ export async function main(argv: string[]): Promise<void> {
}
const config = args.config as Config;

// TODO: use environment (how does current wrangler do it?)
const scriptName = args.name || config.name;
if (!scriptName) {
console.error("Missing script name");
Expand Down Expand Up @@ -912,18 +911,19 @@ export async function main(argv: string[]): Promise<void> {
"password"
);
async function submitSecret() {
return await cfetch(
`/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets/`,
{
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({
name: args.key,
text: secretValue,
type: "secret_text",
}),
}
);
let url = `/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets`;
if (args.env) {
url = `/accounts/${config.account_id}/workers/services/${scriptName}/environments/${args.env}/secrets`;
}
return await cfetch(url, {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({
name: args.key,
text: secretValue,
type: "secret_text",
}),
});
}

try {
Expand Down Expand Up @@ -981,7 +981,6 @@ export async function main(argv: string[]): Promise<void> {
}
const config = args.config as Config;

// TODO: use environment (how does current wrangler do it?)
const scriptName = args.name || config.name;
if (!scriptName) {
throw new Error("Missing script name");
Expand All @@ -1007,16 +1006,18 @@ export async function main(argv: string[]): Promise<void> {

// -- snip, end --

let url = `/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets`;
if (args.env) {
url = `/accounts/${config.account_id}/workers/services/${scriptName}/environments/${args.env}/secrets`;
}

if (await confirm("Are you sure you want to delete this secret?")) {
console.log(
`Deleting the secret ${args.key} on script ${scriptName}.`
);

console.log(
await cfetch(
`/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets/${args.key}`,
{ method: "DELETE" }
)
await cfetch(`${url}/${args.key}`, { method: "DELETE" })
);
}
}
Expand All @@ -1043,7 +1044,6 @@ export async function main(argv: string[]): Promise<void> {
}
const config = args.config as Config;

// TODO: use environment (how does current wrangler do it?)
const scriptName = args.name || config.name;
if (!scriptName) {
console.error("Missing script name");
Expand All @@ -1070,11 +1070,12 @@ export async function main(argv: string[]): Promise<void> {

// -- snip, end --

console.log(
await cfetch(
`/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets`
)
);
let url = `/accounts/${config.account_id}/workers/scripts/${scriptName}/secrets`;
if (args.env) {
url = `/accounts/${config.account_id}/workers/services/${scriptName}/environments/${args.env}/secrets`;
}

console.log(await cfetch(url));
}
);
}
Expand Down