Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to debian bookworm (ruby 3.1) #197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oppegard
Copy link
Member

@oppegard oppegard commented Jul 29, 2024

What is this change about?

This upgrades the Dockerfile to Debian bookworm.

Please provide contextual information.

The primary reason for the change is to address #191. We need a newer version of ruby that supports the latest release of the bosh-template gem used in RSpec suites.

Please check all that apply for this PR:

  • introduces a new task
  • changes an existing task
  • changes the Dockerfile
  • introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

How should this change be described in release notes?

Upgrade to Debian bookworm (ruby 2.7 -> 3.1) in Dockerfile.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

cc @ctlong

@ctlong
Copy link
Member

ctlong commented Jul 30, 2024

This is a major release of this docker file so I'm a little hesitant to merge it so soon after the most recent major. Additionally, we should probably test this against the lone ruby project in this repo – if you haven't done so already?

Upgraded bundler because using the prior version
with Ruby 3.1 resulted in a bunch of deprecation
messages like:

`bundler-2.0.1/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2`
@oppegard
Copy link
Member Author

oppegard commented Aug 7, 2024

I ran the test suite in ci/tasks/cf-decota-release-notes-template and everything passed (which prompted a bundler upgrade to get rid of a deprecation message that was repeated over and over).

Feel free to let this PR sit, or I can close it if you'd like to wait awhile before a new major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants