-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tip to restart app when enabling ssh #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wanddynosios, can you please create and link PRs for the main
branch and potentially for v7
?
I'm wondering what is missing to get this in? |
d7280b3
to
eb80409
Compare
So am I. The PR has been reviewed a while ago already. |
I also asked in the CLI Slack channel https://cloudfoundry.slack.com/archives/C032824SM/p1686818021365519 |
Does this PR modify CLI v6, CLI v7, or CLI v8?
v8
Description of the Change
This PR adds a 'TIP' to restart the app when enabling ssh:
Complies with style guide
Why Is This PR Valuable?
As a cloud foundry operator I often get questions from customers about cf ssh "not working", because it is not obvious that a restart is necessary.
Why Should This Be In Core?
Applicable Issues
#2133 (comment)
How Urgent Is The Change?
Other Relevant Parties