Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tip to restart app when enabling ssh #2314

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

wanddynosios
Copy link
Contributor

Does this PR modify CLI v6, CLI v7, or CLI v8?

v8

Description of the Change

This PR adds a 'TIP' to restart the app when enabling ssh:

➜  out git:(v8) ✗ ./cf-cli_macosarm disable-ssh my-app
Disabling ssh support for app my-app as my-user...
OK

➜  out git:(v8) ✗ ./cf-cli_macosarm enable-ssh my-app 
Enabling ssh support for app my-app as my-user...
OK

TIP: An app restart is required for the change to take effect.
➜  out git:(v8) ✗ ./cf-cli_macosarm enable-ssh my-app
Enabling ssh support for app my-app as my-user...
ssh support for app 'my-app' is already enabled.
OK

TIP: An app restart may be required for the change to take effect.

Complies with style guide

Why Is This PR Valuable?

As a cloud foundry operator I often get questions from customers about cf ssh "not working", because it is not obvious that a restart is necessary.

Why Should This Be In Core?

Applicable Issues

#2133 (comment)

How Urgent Is The Change?

Other Relevant Parties

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 9, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanddynosios, can you please create and link PRs for the main branch and potentially for v7?

@wanddynosios
Copy link
Contributor Author

@a-b I created #2360 and #2361.

Thanks!

@beyhan
Copy link
Member

beyhan commented Apr 14, 2023

I'm wondering what is missing to get this in?

@wanddynosios
Copy link
Contributor Author

I'm wondering what is missing to get this in?

So am I. The PR has been reviewed a while ago already.

@beyhan
Copy link
Member

beyhan commented Jun 15, 2023

I also asked in the CLI Slack channel https://cloudfoundry.slack.com/archives/C032824SM/p1686818021365519

@ccjaimes ccjaimes merged commit 6c371aa into cloudfoundry:v8 Oct 12, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants