Support cf login -u when targeting Korifi / Kubernetes
#2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic was formerly in the auth command, but this will allow for reuse in the login command. [cloudfoundry/korifi#2195] Co-authored-by: Dave Walter <walterda@vmware.com>
- Stop using `k8s-auth-info` for kubernetes prompts and credentials and use `username` instead. This allows the existing login code to work with korifi with fewer changes. - Remove support for menu-based prompts in login except for username. These menus are only used with korifi and only for the username. - Warn the user when they provide a password and are using korifi [cloudfoundry/korifi#2195] Co-authored-by: Dave Walter <walterda@vmware.com>
We ignore the password when authenticating against Kubernetes in both commands. [cloudfoundry/korifi#2195] Co-authored-by: Dave Walter <walterda@vmware.com>
|
Closed and reopened to trigger another run of the tests. It looked like there was an issue with the test infrastructure when we initially submitted it. |
|
Looks good to me. @a-b What do you think? |
|
We will observe the integration test run in V8 branch, since running tests off PR branches is now broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
The PR modifies v8
Description of the Change
cf login -unow works when authenticating against Kubernetes. It will warn if a password is provided. We added the same warning tocf authWhy Is This PR Valuable?
It furthers support for Korifi by supporting more workflows
Why Should This Be In Core?
To further support integration with Korifi
Applicable Issues
cloudfoundry/korifi#2195
How Urgent Is The Change?
This change isn't urgent but merging sooner will avoid us needing to rebasing later
Other Relevant Parties
We aren't aware of any