Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gobump v7 #2418

Merged
merged 1 commit into from
May 9, 2023
Merged

Gobump v7 #2418

merged 1 commit into from
May 9, 2023

Conversation

evanfarrar
Copy link
Member

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

v7

Description of the Change

Bump to golang 1.20. I did not update all go mods, just x/crypto. Should I have? I don't know why the go mods were different than on v8 so I didn't bump them to be safe.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Why Should This Be In Core?

Not a new feature.

Applicable Issues

n/a

How Urgent Is The Change?

How urgent are the CVEs?

Other Relevant Parties

n/a

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: evanfarrar / name: Evan Farrar (8623ab4)

@a-b
Copy link
Member

a-b commented May 9, 2023

I'm curious why 2k files are affected. This looks wrong

@evanfarrar evanfarrar changed the base branch from main to v7 May 9, 2023 17:52
@evanfarrar evanfarrar closed this May 9, 2023
@evanfarrar evanfarrar reopened this May 9, 2023
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit 7ac2734 into cloudfoundry:v7 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants