Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ruby buildpack v7 #2518

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Use latest ruby buildpack v7 #2518

merged 1 commit into from
Aug 25, 2023

Conversation

moleske
Copy link
Member

@moleske moleske commented Aug 25, 2023

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

probably everywhere, still learning how this all works

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

immediate as it will unblock v7 min capi pipelines
Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

- the old cf-d being used deploys a really old ruby-buildpack that doesn't have ruby 3
- this brings in latest ruby-buildpack
- requires this pr to be merged cloudfoundry/cli-ci#10

Co-authored-by: Cristhian Peña <cpena@vmware.com>
@moleske moleske requested review from a team August 25, 2023 18:11
@a-b a-b merged commit 806c6c9 into v7 Aug 25, 2023
12 of 13 checks passed
@a-b a-b deleted the uselatestrubybuildpackv7 branch August 25, 2023 20:43
@gflex gflex mentioned this pull request Aug 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants