-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add cpu entitlement to app process table #2840
Conversation
Shows the new CPU Entitlement metric in the app process table, under the heading `cpu entitlement`. If CPU Entitlement metrics are not available (e.g. deployment does not support it, app is stopped, etc.) for a process instance, then that row will show an empty value. Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
5fc0821
to
6f01b79
Compare
We're not sure why this change is failing unit tests in macOS... it seems unrelated to our changes. When we run unit tests on the |
Using the following command, I was able to run unit tests for this branch on my local mac 23 times in a row without failure: CF_HOME=$PWD/fixtures CF_USERNAME="" CF_PASSWORD="" ginkgo -r -randomize-all -require-suite -randomize-suites -skip-package integration,cf/ssh,plugin,cf/actors/plugin,cf/commands/plugin,cf/actors/plugin,util/randomword -until-it-fails |
I like clicking rerun so I've unstuck the pr checks (for now) Please also open a pr against the main branch as any changes in the v8 branch we'll want in main as well |
We've another change in progress for Where this change represents the "alternative option" described in #2812, for cf CLI v9 we're aiming for the proposed solution in that issue, which we prefer 😄 |
Shows the new CPU Entitlement metric in the app process table, under the heading `cpu entitlement`. If CPU Entitlement metrics are not available (e.g. deployment does not support it, app is stopped, etc.) for a process instance, then that row will show an empty value. Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
Where this PR should be backported?
Description of the Change
Extend the v8 cf CLI to support showing the new CPU Entitlement metric as a non-breaking change, with the
cpu entitlement
column appearing before the details column:If the cpu entitlement stats are not available (e.g. deployment does not support it, app is stopped, etc.) then the cf CLI should show an empty value for the process column.
Why Is This PR Valuable?
Extend the v8 cf CLI to support showing the new CPU Entitlement metric, where applicable.
Applicable Issues
How Urgent Is The Change?
Slightly less than urgent.
Other Relevant Parties
@rroberts2222