Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replace redis file #3046

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add replace redis file #3046

merged 2 commits into from
Jul 25, 2024

Conversation

moleske
Copy link
Member

@moleske moleske commented Jul 25, 2024

  • taken from 8620013 which was done on main and v8 already to resolve issues

cc @gururajsh, @chinigo and @Samze since all you all were on the pr that I linked to above

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main, v8 and v7) as needed.

Description of the Change

add replace redis ops file like the v8 and main branches

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

cause v7 pipeline doesn't work on prs and it makes me sad
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

very assuming we want to keep v7 alive and running and up to date on dependencies
Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

- taken from 8620013 which was done on main and v8 already to resolve issues
@moleske moleske requested review from a team July 25, 2024 02:28
@moleske
Copy link
Member Author

moleske commented Jul 25, 2024

note to self - recreate #3044 and #3043 after merge so dependabot will actually run the integration tests

@moleske
Copy link
Member Author

moleske commented Jul 25, 2024

Integration failing cause it uses what is committed to v7, not what is in the pr (or at least that's my understanding, correct me please if that is wrong)

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.

LGTM

@gururajsh gururajsh merged commit 1c3b714 into v7 Jul 25, 2024
12 of 14 checks passed
@gururajsh gururajsh deleted the v7-replace-redis-with-valkey-for-capi branch July 25, 2024 13:31
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants