Fix pickling when pytest is loaded. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 2 2
Lines 551 551
Branches 107 107
=======================================
Hits 458 458
Misses 65 65
Partials 28 28
Continue to review full report at Codecov.
|
rgbkrk
reviewed
Jul 25, 2017
| @@ -384,7 +384,7 @@ def _save_subimports(self, code, top_level_dependencies): | |||
| # check if the package has any currently loaded sub-imports | |||
| prefix = x.__name__ + '.' | |||
| for name, module in sys.modules.items(): | |||
| if name.startswith(prefix): | |||
There was a problem hiding this comment.
Would be great to have a comment here about why we check on the name being None.
Older versions of pytest will add a "None" module to sys.modules.
rgbkrk
approved these changes
Jul 26, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of pytest will add a "None" module to
sys.modules.This was removed rather recently pytest-dev/pytest#2106, so this PR prevents that old code from breaking things.