Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use pickle5 (Redux) #370
Optionally use pickle5 (Redux) #370
Changes from 95 commits
a860509
ee722f1
d69ca86
6264641
dc9ba84
d5ed4d9
c44ad88
fd67f4b
9740b22
c657fe1
1f2410f
ebaf7f6
1d6abbd
fb34d27
a15782f
35e39d0
a03a1ab
cdaeec5
95fdce0
38ed5f5
5334e79
abbb978
eb536de
53111d3
9d56632
9e92413
043ff81
09d9e33
f74372a
829b919
f693401
46405e5
f57df63
df6fa9b
20a522b
3908dfe
e5deaf6
ff2baa9
13a76f9
393b312
52746b9
b531b14
e85ab4d
2a82a41
21c82b9
4fb4ca5
5909c38
2822390
d239943
8deef74
bb3436f
884ee89
3b98492
0469528
371d015
d661ce6
4de14b2
a0f8d73
ca07fce
96fe5c0
78602e2
dad2938
4dcbf3e
677a114
cd7cd1a
8eba950
bff0786
fccb9e3
0d11d66
0522cfb
149b01e
695cbb8
adc1220
71dcd2a
e4fc3a0
e41b4dd
4688643
5bfb9f3
794cd9d
b9ccea7
afec159
1dc8dd8
9502999
6530ff6
7aabd2a
4d33877
5800bb6
4e1bc25
cc5efb2
ec3468e
d588774
7b3f1a7
8178a2c
dc8bd28
8a890f5
5cdb5e1
268778b
f17b31a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we don't have to skip
numpy
+Python 3.5
after all? nice :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed :) PR ( numpy/numpy#16439 ) added Python 3.5 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using
cloudpickle.compat.pickle
orpickle
should be equivalent in theload
case right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto:
cloudpickle.compat.pickle
andpickle
are interchangeable in this situation right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In both of these test cases, we are using the highest supported protocol with
cloudpickle
, which is protocol5
, to produce the pickled data. So we wound up needing to change these since we are trying to load the pickled data and then need to usepickle5
whenpickle
doesn't have protocol5
support. We could alternatively skip the test, restrict the protocol based onpickle.HIGHEST_PROTOCOL
, or something else. We could also leave as-is. Some options to consider 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I agree. Thanks.