Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudposse/github-action-deploy-helmfile action to v0.5.0 #46

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 15, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/github-action-deploy-helmfile action minor 0.3.0 -> 0.5.0

Release Notes

cloudposse/github-action-deploy-helmfile

v0.5.0

Compare Source

Handle multiple matching ingresses for output-url @​ozydingo (#​35)

Github actions cannot support having multiple output urls for an environment. Switch the strategy to use jq's first function so that at least some valid URL is displayed if present. Punts on how to determine which URL would be preferred in the case of multiple.

what
  • Output only a single URL for webapp-url when a deployment has multiple ingresses
  • Choose the first matching ingress as a reasonable guess as to which ingress is preferred to display in the github action step.
why
  • When there are multiple ingresses, the current script outputs all of their URLS:
⨠ kubectl --namespace pr-13904 get -l app.kubernetes.io/name=app ingress --output=jsonpath='{.items[*].metadata.annotations.outputs\.webapp-url}'
https://ops-pr-13904.3paw-dev.com https://ops-pr-13904.3paw-dev.co

This causes the github action to fail to display the environment url

Screen Shot 2023-04-27 at 3 20 10 PM

The URL does not display:

Screen Shot 2023-05-08 at 2 30 55 PM

  • First is a a step in the direction over invalid, though this could get more configurable. (In our case, both ingresses have the same url anyway.)
  • Change to jq from jsonpath since it supports first even if there are no matches. jsonpath using [0], on the other hand, will blow up
testing

Here is a PR that uses the new code, and is showing the preview env URL successfully.

Screen Shot 2023-05-08 at 2 28 02 PM

references

v0.4.0

Compare Source

Use ECR alpine image @​goruha (#​33)
what
  • Use ECR alpine image

  • Avoid docker hub limits hit

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update cloudposse/github-action-deploy-helmfile action to v0.4.0 Update cloudposse/github-action-deploy-helmfile action to v0.5.0 May 9, 2023
@renovate renovate bot force-pushed the renovate/cloudposse-github-action-deploy-helmfile-0.x branch from 3e43abc to fc7f215 Compare May 9, 2023 10:47
@goruha goruha merged commit 08554f6 into main Jun 2, 2023
@goruha goruha deleted the renovate/cloudposse-github-action-deploy-helmfile-0.x branch June 2, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant