Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RunnerSet, use concurrency control #4222

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Dec 9, 2023

what

  • Migrate arm64 workflows to self-hosted Runner Set (from older-style Runners)
  • Add concurrency control to kill builds that are superseded
  • When overriding package version for build, set package "release" to 0 (zero) if not also overridden

why

  • Better autoscaling
  • With PRs like this, all packages rebuild, and if there is a problem, they all get rebuilt, and the earlier builds get thrown away. Using concurrency control with preemption, we don't wast resources on finishing builds that will not be used.
  • Previously, "release" was taken from RELEASE if not overridden. When overriding VERSION, presumably to fill in a missing older version, it does not make sense to use the package release number for the current version.

@Nuru Nuru requested review from a team as code owners December 9, 2023 06:47
@Nuru Nuru merged commit 27ddc48 into master Dec 9, 2023
804 checks passed
@Nuru Nuru deleted the workflow-concurrency branch December 9, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant