Skip to content

Commit

Permalink
feat!: Remove support for node v16 (#242)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Node v16 has been end-of-life since 2023-09-11, so
testing is removed for this version of Node.

Added node version enforcement to package.json.
  • Loading branch information
nielm committed Mar 13, 2024
1 parent 70d0183 commit a5dc70c
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
10 changes: 9 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"Description": "Autoscaling for Cloud Spanner based on CPU metrics",
"homepage": "https://github.com/cloudspannerecosystem/autoscaler",
"license": "Apache-2.0",
"author": "Google Inc.",
"scripts": {
"eslint": "eslint .",
"eslint-fix": "eslint --fix .",
Expand All @@ -17,5 +18,9 @@
"eslint-config-google": "^0.14.0",
"markdownlint-cli": "^0.39.0",
"typescript": "^5.4.2"
},
"engines": {
"node": ">=18.0.0 || >=20.0.0",
"npm": ">=10.0.0"
}
}
1 change: 1 addition & 0 deletions src/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
4 changes: 4 additions & 0 deletions src/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@
},
"scripts": {
"start": "node -e \"require('./index').autoscalerMain()\""
},
"engines": {
"node": ">=18.0.0 || >=20.0.0",
"npm": ">=10.0.0"
}
}

0 comments on commit a5dc70c

Please sign in to comment.