Merge pull request #974 from cms-analysis/inf_par_fix

Fix a bug check_inf_parameters
cms-analysis · Jun 18, 2024 · 02eaddc · 02eaddc
2 parents 0731178 + 03067d8
commit 02eaddc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/cvmfs-ci.yml b/.github/workflows/cvmfs-ci.yml
@@ -56,6 +56,9 @@ jobs:
             text2workspace.py HiggsAnalysis/CombinedLimit/data/tutorials/CAT23001/datacard-5-multi-signal.txt -P HiggsAnalysis.CombinedLimit.PhysicsModel:floatingXSHiggs --PO modes=ggH,qqH -o datacard-5-multi-signal.root --mass 125
             combine datacard-5-multi-signal.root -M MultiDimFit --algo singles --mass 125
             combine HiggsAnalysis/CombinedLimit/data/tutorials/CAT23001/datacard-5-multi-signal.txt -M ChannelCompatibilityCheck --mass 125
+            text2workspace.py  HiggsAnalysis/CombinedLimit/data/tutorials/multiDim/toy-hgg-125.txt -m 125 -P HiggsAnalysis.CombinedLimit.PhysicsModel:floatingXSHiggs --PO modes=ggH,qqH
+            combine -M MultiDimFit HiggsAnalysis/CombinedLimit/data/tutorials/multiDim/toy-hgg-125.root
+
 
 
 
diff --git a/src/utils.cc b/src/utils.cc
@@ -892,11 +892,18 @@ void utils::check_inf_parameters(const RooArgSet & params, int verbosity) {
     for (RooAbsArg *arg : params) {    
         RooRealVar *p = dynamic_cast<RooRealVar *>(arg);
         if (p->getRange().first <= -infinity_root626 || p->getRange().second >= +infinity_root626){
+
             if ( verbosity > 2 ) {
                 std::cout << "Found a parameter named "<< p->GetName()
-                          << " infinite in ROOT versions < 6.30, going to removeRange()" << endl;
+                          << " infinite in ROOT versions < 6.30, going to update the ranges to take into account the new definition of infinity in ROOT v6.30" << endl;
+            }
+            if (p->getRange().first <= -infinity_root626 && p->getRange().second >= +infinity_root626) {
+              p->removeRange();
+            } else if (p->getRange().second >= +infinity_root626) {
+              p->removeMax();
+            } else {
+              p->removeMin();
             }
-            p->removeRange();
         }
     }
 }