Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex float parameters docs #866

Merged

Conversation

kcormi
Copy link
Collaborator

@kcormi kcormi commented Oct 10, 2023

This is adding some minor documentation to make it clear that regex are also available for the --floatParameters option, as per #851.

I've simply separated the documentation so that it is updated on the next recommended version update, and not before. This branch should be merged when we make that change.

@kcormi kcormi added the documentation Updates for the documentation label Oct 10, 2023
@kcormi
Copy link
Collaborator Author

kcormi commented Oct 10, 2023

I've also added a minor documentation update for ChannelCompatibilityCheck to document the -g option in the online docs and the ability to set ranges for individual POIs via this option, as in #760

@kcormi kcormi force-pushed the regex-float-parameters-docs branch from e8e920d to 6171a36 Compare October 10, 2023 13:40
@nucleosynthesis
Copy link
Contributor

All looks good to me, I think we can merge this one

@anigamova
Copy link
Collaborator

Perhaps we should wait with this PR until we are ready to release a new version, this feature is not available in v9.1 yet

@nucleosynthesis
Copy link
Contributor

Hi @kcormi - looks like we now have conflicts after the checks from Adinda. Can you see if those can be fixed and we go ahead and merge this?

@kcormi
Copy link
Collaborator Author

kcormi commented Dec 14, 2023

I've just resolved the conflicts, I think it should be fine to merge now, which we can do whenever we make the new release.

@nucleosynthesis
Copy link
Contributor

I'll merge this one now, to make sure its in for the next Tag

@nucleosynthesis nucleosynthesis merged commit f3aa5fe into cms-analysis:main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates for the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants