Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nckw new logger #868

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Nckw new logger #868

merged 5 commits into from
Dec 4, 2023

Conversation

nucleosynthesis
Copy link
Contributor

Minimial version of CombineLogger written.
Replaces Logger with stripped down version (CombineLogger)

Nick Wardle added 2 commits October 23, 2023 12:20
Replace Logger with stripped down version (CombineLogger)
@nucleosynthesis
Copy link
Contributor Author

Currently, the log file name defaults to the previous combine_logger.out but functionality is there to specify a name. This needs to be done here : https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/nckw_new_Logger/bin/combine.cpp#L55 , however the code is structured so that string components that make up the ROOT file name are created much later so formatting the same as the file name would require some restructuring.

@nucleosynthesis
Copy link
Contributor Author

I think there's a lot of good progress here so I'd be in favour of merging and then we can make more improvements down the road @giacomoortona ?

@giacomoortona
Copy link
Collaborator

Agree

@nucleosynthesis nucleosynthesis merged commit b47ce81 into main Dec 4, 2023
6 checks passed
@nucleosynthesis nucleosynthesis deleted the nckw_new_Logger branch December 4, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants