Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DoubleSidedGausssian pdf #870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjkwon260
Copy link

add DoubleSidedGausssian pdf which is used for boosted H->aa->mumutautau analysis (SUS-23-005/HIG-18-024) for signal modelling.
It compiles/works in local test.

RooRealProxy sig1 ;
RooRealProxy sig2 ;
Double_t evaluate() const ;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class doesn't implement anaytical integral capabilities, so it will be always integrated numerically. That's a major performance hit.


private:

Double_t yMax;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yMax is not used anywhere, right? Why is it needed?

@guitargeek
Copy link
Contributor

guitargeek commented Dec 2, 2023

Hi @hjkwon260!

Please consider using the equivalent class that is already in RooFit, which also supports analytical normalization integrals, etc.:

It should be avoided that RooFit functionality is duplicated in experiment frameworks, because this puts an unnecessary maintenance burden on the combine devs.

Or did I overlook something and there is a mathematical difference between your DoubleSidedGaussian and RooFits RooBifurGauss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants