Update README.md #944
Update README.md #944
Conversation
Small text changes.
| @@ -12,17 +12,17 @@ The files in this directory are: | |||
|
|
|||
| For simplicity, this tutorial does not discuss scans using `-M MultiDimFit --algo=grid`, | |||
| but rather uses `-M MaxLikelihoodFit --robustFit=1` | |||
There was a problem hiding this comment.
I was too slow to add a comment but since we are updating this, we probably want to modify MaxLikelihoodFit -> FitDiagnostics since the former is no longer the method name
There was a problem hiding this comment.
@adavidzh @anigamova (fth), can we update again with this fix?
There was a problem hiding this comment.
there is a Makefile in this folder that needs an update too, e.g. the fit options seem to be outdated https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/data/tutorials/groups/Makefile#L113
I think this tutorial needs some refactoring along the lines https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest/part5/longexercise/#e-signal-strength-measurement-and-uncertainty-breakdown
There was a problem hiding this comment.
Or maybe we could just add some grouping instructions there? or do you prefer to keep the Makefile @adavidzh ?
Small text changes.