Remove default requirements from DataFrameWrapper #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DataFrameWrapper, can assume that if shape lines don't include `:nominal,sum_w:sum_ww` extension, then we can just add them internally. This avoids users having to write boilerplate in datacards making these more similar to TH1 type. Not changes to tutorial datacard.
Missing `End` in `printEndExpand`
…hub.com/cms-analysis/HiggsAnalysis-CombinedLimit into nucleosynthesis-update-DataFrameWrapper
|
The only failing check is the 6.24 ROOT compile, which is being removed from the CI so I think this is ok now |
|
yes, this root 6.24 job was also failed in several other PRs due to some numpy version incompatibility, merging then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DataFrameWrapper, can assume that if shape lines don't include
:nominal,sum_w:sum_wwextension, then we can just add them internally.This avoids users having to write boilerplate in datacards making these more similar to TH1 type.
Not changes to tutorial datacard.