Fix concurrent modification error in AuctionMark #357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
updateItemQueues
function, the code iterates each item queue and calls theaddItemToProperQueue
for each item. One step this function does is remove the item from the original list, if the new status is different from the old one.This, however, triggers a
ConcurrentModificationException
exception since we are iterating and removing concurrently from the linked list:The proposed solution passes a reference to the iterator in the
updateItemQueues
function, so theaddItemToProperQueue
can safely remove the element usingiterator.remove()
. This also means that the code in theaddItemToProperQueue
function does not need to iterate over the entire list again by callingremove
, improving performance. The other functions that callupdateItemQueues
seem to be always new items, so we can set the iterator as null as they don't need to remove from an existing queue.